This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
TryteString.random() use cls.LEN as its default length, when available #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
suggested changes
Mar 18, 2018
iota/types.py
Outdated
| @@ -60,6 +60,12 @@ def random(cls, length): | |||
| alphabet = list(itervalues(AsciiTrytesCodec.alphabet)) | |||
| generator = SystemRandom() | |||
|
|
|||
| try: | |||
| length = length or cls.LEN | |||
There was a problem hiding this comment.
This would also trip if length == 0; could we change this to an explicit is None check?
iota/types.py
Outdated
| length = length or cls.LEN | ||
| except AttributeError: # class has no LEN attribute | ||
| if length is None: | ||
| raise TypeError("random() missing 1 required positional argument: 'length'") |
There was a problem hiding this comment.
I feel like this might be confusing to some users, since the method signature shows length as optional.
Maybe we could make this error explain that {class} does not define a length property.
|
Hi @rpitonak let me know if there's anything I can do to help with this! |
|
Thanks @rpitonak ! I will take a look at this over the weekend. |
|
Cheers @rpitonak ! The changes look good. Two last things:
|
|
Change implemented in another PR, see #286 for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #166